Comments on: reek, a code smells detector for ruby

By: TMTC 19 – Kevin Rutherford Interview | Teach Me To Code

TMTC 19 – Kevin Rutherford Interview | Teach Me To Code — Fri, 13 May 2011 18:23:17 +0000

[...] He’s an agile coach, and blogs at http://silkandspinach.net. Finally, he has written the reek tool, which identifies code smells in your [...]

By: TMTC 19 – Kevin Rutherford Interview — Teach Me To Code Podcast

TMTC 19 – Kevin Rutherford Interview — Teach Me To Code Podcast — Fri, 06 Aug 2010 05:34:02 +0000

[...] He’s an agile coach, and blogs at http://silkandspinach.net. Finally, he has written the reek tool, which identifies code smells in your [...]

By: TMTC 19 – Kevin Rutherford Interview | Teachmetocode Podcast

TMTC 19 – Kevin Rutherford Interview | Teachmetocode Podcast — Wed, 12 May 2010 19:22:09 +0000

[...] He’s an agile coach, and blogs at http://silkandspinach.net. Finally, he has written the reek tool, which identifies code smells in your [...]

By: Kevin Rutherford

Kevin Rutherford — Thu, 11 Jun 2009 11:37:33 +0000

@hasan, thanks for taking the time to make a patch! I’ll look at your code soon; in the meantime, I know that Roodi (http://rubyforge.org/projects/roodi/) does some of the same checks — have you seen it?

By: nhm tanveer hossain khan (hasan)

nhm tanveer hossain khan (hasan) — Thu, 11 Jun 2009 10:04:38 +0000

hi,
thanx for such a nice tool :) i just forked your code on GitHub. added an interesting feature.

now i can apply my own custom rules in ruby code and configure them over *.reek configuration file. please have a look on it –

http://github.com/teksymmetry/reek/tree/master

i wanted to check more strict variable convention. such as “is_found = …” “can_found = …” or “user_Name = …” kinda variable names will be treated as convention error.

“is/can/has” etc can’t be used in variable name more over no one can mistakenly use upper case in variable name, ie. “useR_name”

best wishes, thnx for nice work.

By: » Детектор “плохих запа … QAлификация

» Детектор “плохих запа … QAлификация — Mon, 03 Nov 2008 07:05:30 +0000

[...] “плохих запахов” для rubyrub http://silkandspinach.net/2008/09/23/reek-a-code-smells-detector-for-ruby/ [...]

By: Kevin Rutherford

Kevin Rutherford — Tue, 28 Oct 2008 16:03:34 +0000

@Dean: I often get the same warnings; they usually occur when I accidentally let reek look at rspec files. Try passing a set of files on the command line, or change to a folder where reek can’t see your tests — does that help?

By: Dean Wampler

Dean Wampler — Tue, 28 Oct 2008 15:52:04 +0000

Kevin,
Very nice. Much needed!

I’m getting dozens of warnings like:

(string):47: warning: useless use of == in void context

I’m using the latest ParseTree (and probably the latest of the other gems…) on OS X.

Also, it looks like the output doesn’t list the file with the flagged issue.

By: Giles Bowkett

Giles Bowkett — Mon, 27 Oct 2008 16:20:13 +0000

Hey Kevin, this is insanely awesome. I love it. Do you run it on Rails controllers at all? I’m unsure of the seriousness of Feature Envy and Utility Function warnings there. I’m going to look at the code. It might make sense to have wrapper classes which configure or weight the evaluations, e.g., Feature Envy is OK in all controllers, Utility Function is OK in application controller, neither one is OK in a model, etc. I’m kind of undecided as to whether or not it’s a good idea, though. What do you think?

By: ESPN Dev Blog » Blog Archive » Ruby Style Guides and Tools

ESPN Dev Blog » Blog Archive » Ruby Style Guides and Tools — Mon, 27 Oct 2008 16:07:32 +0000

[...] highlights two useful posts about Ruby style (here and here) and includes a link to reek, a popular tool for sniffing out code smells. Read More [...]

By: Ruby Style Guides and Tools: How to Write Good Looking Ruby

Ruby Style Guides and Tools: How to Write Good Looking Ruby — Mon, 27 Oct 2008 11:43:46 +0000

[...] month, Kevin Rutherford released reek, a “code smells [...]

By: เร็วส์ หกสิบหก » นั่งเทียนเขียนข่าว#20

เร็วส์ หกสิบหก » นั่งเทียนเขียนข่าว#20 — Sun, 26 Oct 2008 08:36:11 +0000

[...] reek, a code smells detector for ruby « silk and spinach [...]

By: Kevin Rutherford

Kevin Rutherford — Thu, 23 Oct 2008 19:21:35 +0000

@Aditya: Yeah, I get the same thing. I develop on Ubuntu, but it certainly used to work on Windows with earlier versions of ParseTree. I’ll investigate over the weekend, but right now it looks like ParseTree has stopped working on Windows…

By: Aditya Sanghi

Aditya Sanghi — Thu, 23 Oct 2008 12:01:41 +0000

Oh one more thing, does it not run on Windows? After i fixed (read updated) my ZenTest,ParseTree and the RubyInline gems to the latest version i got past the above error.

However now the error is
c:/ruby/lib/ruby/gems/1.8/gems/RubyInline-3.8.0/lib/inline.rb:578:in “’: No such file or directory – cl -nologo -LD -MD -Zi -O2b2xg- -G6 -I c:/ruby/lib/ruby/1.8/i386-mswin32 -I c:/ruby/include -Lc:/ruby/lib -o “c:\\.ruby_inline/Inl
ine_RawParseTree_fa12.so” “c:/.ruby_inline/Inline_RawParseTree_fa12.c” -link /LIBPATH:”c:/ruby/lib” /DEFAULTLIB:”msvcrt-ruby18.lib” /INCREMENTAL:no /EXPORT:Init_Inline_RawParseTree_fa12 (Errno::ENOENT)

Although, I tried it on my ubuntu version and it
worked.

Cheers,
Aditya

By: Aditya Sanghi

Aditya Sanghi — Thu, 23 Oct 2008 11:17:20 +0000

Hi!

rubygems.rb:142:in `activate’: can’t activate ParseTree (= 2.1.1, runtime), already activated ParseTree-2.2.0 (Gem::Exception)

I think I have a newer version of ParseTree, should that be a problem? Does this really need version ParseTree version=2.1.1? If yes, maybe the gem spec should install it for me? If not, maybe we need a >= 2.1.1?

Really looking forward to using it!!

Cheers,
Aditya